Cleanup crc32c soft dependency
#637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
cleanup_crc32_c_soft
branch
2 times, most recently
from
f2c5a8b to
2cc8d48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 62 62
Lines 2708 2723 +15
=======================================
+ Hits 2705 2720 +15
Misses 3 3
|
jakirkham
force-pushed
the
cleanup_crc32_c_soft
branch
3 times, most recently
from
822f376 to
e5d4566
Compare
jakirkham
commented
Nov 14, 2024
Member
Author
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Seeing some issues with mypy below. Flagged relevant lines that may need changes. Please let me know if there is a good way to address this
jakirkham
force-pushed
the
cleanup_crc32_c_soft
branch
from
e5d4566 to
59fa05c
Compare
3 tasks
jakirkham
force-pushed
the
cleanup_crc32_c_soft
branch
from
59fa05c to
afce731
Compare
Member
Author
|
Fixed the mypy issues in recent changes |
dstansby
reviewed
Nov 14, 2024
dstansby
approved these changes
Nov 15, 2024
Contributor
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
Looks good - just needs a changelog entry 👍
jakirkham
commented
Nov 15, 2024
Member
Author
|
Thanks David! 🙏 Please let me know if there is anything else |
Member
Author
|
Closing and reopening for CI (specifically coverage) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a wrapper function around the call to
crc32c's to check if it can beimported. Tryimportingcrc32cwhennumcodecs.checksum32isimported. If it cannot beimported, don't define theCRC32Cclass and skip registering it at the top-level with otherCodecs.This matches the behavior that Numcodecs has with all other optional codecs and cuts out unneeded overhead when using this checksum routine.
xref: #613
TODO: